Skip to content

fix(oauth): honor discovered CIMD support - #1732

Open
aryasaatvik wants to merge 2 commits into
UsefulSoftwareCo:mainfrom
aryasaatvik:fix/mcp-cimd-discovery-upstream
Open

fix(oauth): honor discovered CIMD support#1732
aryasaatvik wants to merge 2 commits into
UsefulSoftwareCo:mainfrom
aryasaatvik:fix/mcp-cimd-discovery-upstream

Conversation

@aryasaatvik

@aryasaatvik aryasaatvik commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary

Prefer Client ID Metadata Documents when OAuth discovery advertises CIMD, including servers that also expose dynamic client registration. Automatic MCP OAuth now follows the server-advertised client path instead of incorrectly asking the user for manual app registration.

Flow

reserve popup -> probe OAuth discovery
  -> CIMD: create or reuse metadata client -> start OAuth
  -> otherwise DCR: register client -> start OAuth
  -> otherwise: show manual client setup

The UI consumes the SDK canonical OAuthProbeResult, preventing discovery capabilities from being dropped by a duplicated UI-only type.

Validation

  • React add-account modal suite: 45 tests passed.
  • React and SDK typecheck, format, and lint passed.
  • Selfhost MCP OAuth CIMD browser E2E passed with recording and trace.
  • All 36 applicable GitHub CI checks passed at 4e3b63f69.

@aryasaatvik
aryasaatvik marked this pull request as ready for review August 25, 2026 21:51
@aryasaatvik
aryasaatvik force-pushed the fix/mcp-cimd-discovery-upstream branch from 1c1536f to eb4ecce Compare August 27, 2026 16:31
@aryasaatvik
aryasaatvik force-pushed the fix/mcp-cimd-discovery-upstream branch from eb4ecce to 4e3b63f Compare August 27, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant